2.4K Star 8.2K Fork 4.4K

GVPMindSpore / mindspore

 / 详情

[CT][MS] tripletmarginloss 算子reduction 设置为 None 时shape计算结果错误

TODO
RFC
Opened this issue  
2023-07-13 16:55

Describe the current behavior / 问题描述 (Mandatory / 必填)

gpu
tripletmarginloss 算子reduction 设置为 None 时shape计算结果错误
设置为sum mean时有精度误差 可能是同一问题
5.9执行成功
mindspore_commit=commit_id = '[sha1]:3a940e7d,[branch]:(HEAD,origin/r2.0,r2.0)'
5.10之后执行失败
mindspore_commit=commit_id = '[sha1]:e4c008ea,[branch]:(HEAD,origin/r2.0,r2.0)'

Environment / 环境信息 (Mandatory / 必填)

  • Hardware Environment(Ascend/GPU/CPU) / 硬件环境:

Please delete the backend not involved / 请删除不涉及的后端:
/device GPU

  • Software Environment / 软件环境 (Mandatory / 必填):
    -- MindSpore version (e.g., 1.7.0.Bxxx) :
    -- Python version (e.g., Python 3.7.5) :
    -- OS platform and distribution (e.g., Linux Ubuntu 16.04):
    -- GCC/Compiler version (if compiled from source):

  • Excute Mode / 执行模式 (Mandatory / 必填)(PyNative/Graph):

Please delete the mode not involved / 请删除不涉及的模式:
/mode pynative
/mode graph

Related testcase / 关联用例 (Mandatory / 必填)

test_dynamic_shape_p_tripletmarginloss_input_6d_float64

Steps to reproduce the issue / 重现步骤 (Mandatory / 必填)

  1. 执行用例

Describe the expected behavior / 预期结果 (Mandatory / 必填)

pass

Related log / screenshot / 日志 / 截图 (Mandatory / 必填)

输入图片说明

Special notes for this issue/备注 (Optional / 选填)

Comments (6)

张旭 createdBug-Report
张旭 added
 
kind/bug
label
张旭 added
 
v2.2.0
label
张旭 added
 
sig/mslite
label
Expand operation logs

Please assign maintainer to check this issue.
请为此issue分配处理人。
@张旭

Please add labels (comp or sig), also you can visit https://gitee.com/mindspore/community/blob/master/sigs/dx/docs/labels.md to find more.
为了让代码尽快被审核,请您为Pull Request打上 组件(comp)或兴趣组(sig) 标签,打上标签的PR可直接推送给责任人进行审核。
更多的标签可以查看https://gitee.com/mindspore/community/blob/master/sigs/dx/docs/labels.md
以组件相关代码提交为例,如果你提交的是data组件代码,你可以这样评论:
//comp/data
当然你也可以邀请data SIG组来审核代码,可以这样写:
//sig/data
另外你还可以给这个PR标记类型,例如是bugfix或者是特性需求:
//kind/bug or //kind/feature
恭喜你,你已经学会了使用命令来打标签,接下来就在下面的评论里打上标签吧!

========================================================= test session starts ==========================================================
platform linux -- Python 3.7.5, pytest-5.3.5, py-1.8.1, pluggy-0.13.1 -- /root/miniconda3/envs/zxop3.7/bin/python
cachedir: .pytest_cache
rootdir: /home/zx/2.2feature/MindSporeTest/operations
plugins: timeout-1.4.2, repeat-0.9.1
collected 1 item

test_tripletmarginloss.py::test_dynamic_shape_p_tripletmarginloss_input_6d_float64 PASSED [100%]

=================================================== 1 passed, 119 warnings in 9.98s ====================================================

本地复现使用torch Version: 1.8.1版本,功能ok,能与torch对齐,但是1.12版本,发现结果不一致,原因是因为torch在版本更新过程中对算子的实现逻辑进行了更新,mindspore没有进行更新,与老版本torch一致,与新版本torch不一致。

与另外一个问题单有类似情况:(目前作为需求进行迭代开发)
[CT][MS][ops]tripletmarginloss, 与torch1.12比较,误差超过范围
https://e.gitee.com/mind_spore/issues/table?issue=I76OCI

CCB结论:和之前那个单统一,转需求

yefeng added
 
ccb/rfc
label
yefeng translation missing: en.project.new_issues_operate_log.link_issue(Normal)【众筹】存量算子 tripletmarginloss 功能补齐(如数据类型补齐)及性能优化

已关联相关的需求

yefeng assigned collaborator yefeng
yefeng changed assignee from yefeng to liangchenghui
yefeng changed milestone from B-SIG-MSLite to B-SIG-OPS
liangchenghui changed milestone from B-SIG-OPS to not set
liangchenghui changed issue type from Bug-Report to RFC
yefeng unassigned collaborator yefeng

Sign in to comment

Status
Assignees
Projects
Milestones
Pull Requests
Successfully merging a pull request will close this issue.
Branches
Planed to start   -   Planed to end
-
Top level
Priority
Duration (hours)
参与者(3)
7873411 yefeng 24 1664283327
Python
1
https://gitee.com/mindspore/mindspore.git
git@gitee.com:mindspore/mindspore.git
mindspore
mindspore
mindspore

Search